Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe poetry (https://python-poetry.org/) is a much better solution at managing python dependencies as it prevents conflicts in sub-dependencies.
Rather than
pip install -r requirements.txt
you will need
poetry install
in order to set up the project.
I have renamed the setup.py to setup.py.obsolete as with poetry the pyproject.toml contains the relevant information and the setup.py is built automatically when the distro package is built:
poetry build -f sdist
I tend also to use direnv and pyenv for which I have added and .envrc.example and .env.example (to be renamed without the .example and configured with the environment) and the .python-version to specify the python version(s) that we want to use for development.
I also introduced django-environ which I believe to be a more django friendly alternative to python-dotenv and trying to apply 12 factor best practices where environment variables define all that is needed for the configuration rather than having different settings file.