rework tests to minimize warnings

MidnightBSD · Jan 4, 2024 · 4004724 · 4004724
1 parent e92957b
commit 4004724
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/test/java/org/midnightbsd/appstore/ctl/LicenseControllerTest.java b/src/test/java/org/midnightbsd/appstore/ctl/LicenseControllerTest.java
@@ -40,21 +40,19 @@ public void setup() {
             license.setName("NAME");
             license.setId(1);
             license.setCreated(Calendar.getInstance().getTime());
-
-            when(service.list()).thenReturn(Collections.singletonList(license));
-            when(service.get(1)).thenReturn(license);
-            when(service.getByName("NAME")).thenReturn(license);
         }
 
         @Test
         void testList() {
+            when(service.list()).thenReturn(Collections.singletonList(license));
             final ResponseEntity<List<License>> result = controller.list();
             assertNotNull(result);
             assertEquals(1, Objects.requireNonNull(result.getBody()).size());
         }
 
         @Test
         void testGet() {
+            when(service.get(1)).thenReturn(license);
             final ResponseEntity<License> result = controller.get(1);
             assertNotNull(result);
             assertEquals("NAME", result.getBody().getName());
@@ -63,6 +61,7 @@ void testGet() {
 
         @Test
         void testGetByName() {
+            when(service.getByName("NAME")).thenReturn(license);
             final ResponseEntity<License> result = controller.get("NAME");
             assertNotNull(result);
             assertEquals("NAME", result.getBody().getName());