Use fully qualified domain name in DNS queries #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
SPF checks must be performed on fully qualified domain names (FQDN). This means, that when calling
dns_get_record()
, domain must end with zero-length label (dot).Without dot at the end, resolver may search additional domain names, causing unnecessary delays or wrong results. In my case it tries to search
.local
domain, which tries to resolve non-existent A/AAAA records over mDNS, which causes long delays because of timeouts.Here is a small pull-request to fix this.
BR,
Erki