Fixing regex for identifying IMAP folders by supporting "." delimiter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `update` method in the EmailBox class, there is a regex for checking the returned mail folders from the IMAP_SSL connection. However, this regex does not catch the case where in an inbox is specified in the format `(\\HasNoChildren) "." INBOX`. This is the format returned by my IMAP server and is valid. This commit modifies the regex to allow either the '/' or '.' to separate the flags from the folder name.
Fixing regex for identifying IMAP inbox folders
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the series of commits, I update the EmailBox class such that it supports delimiting the inbox and flags via a ".", which is the format used by some IMAP servers. I test these changes locally and observe that they work correctly.