-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed check that pop via gesture ignored subroutes #1941
base: master
Are you sure you want to change the base?
Conversation
@Milad-Akarie According to my tests everything looks fine on both platforms now. Please check if it is correct. |
LGTM |
Will it fix issue when whole stack is popped instead if one page by swipe back ? |
Yep |
Cool. When it will be merged ? |
Waiting for the review @Milad-Akarie |
Please review this PR @Milad-Akarie |
Hey @iagoandrei checking the routing controller stack for pop possibility is not reliably because of pageless routes, can you check if the fix I released is working for you? |
Doesn't work for me on the latest 8.1.2 |
8.1.3 will be uploaded soon |
yep, can confirm that now it works properly. @iagoandrei can you please also check that it works for you on the latest 8.1.3? |
Not fixed: #1940 |
Fixes: #1932
In the previous PR(#1940) I did not consider when the AutoRouter() widget is not used to build nested routes. This PR corrects the situation when AutoRouter() is not used to build routes.