Use nightly again to build wasm artifacts #16540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
2 times, most recently
from
6e8c1b0 to
3d2484c
Compare
This was referenced Jan 28, 2025
|
!ci-build-me |
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
from
3d2484c to
02241d8
Compare
|
!ci-toolchain-me |
1 similar comment
|
!ci-toolchain-me |
|
!ci-build-me |
nightly has been initially removed as it seemed to make vendoring all the dependencies more complicated because some std lib must be included. However, removing nightly introduces issues like "DataCloneError", see o1-labs/o1js#1989, which makes the reliance on nightly inevitable. Removing --offline because stdlib missing for now (like `compiler_builtins`). Another note is that cargo vendor has been introduced to provide a consistent build environment for all platforms and all users, including the CI. The lockfile Cargo.lock is meant to provide a locked environment with all the dependencies, including the transitive ones. However, it is only used by binaries. In our build process, we do build a static library (libwires_15_stubs.a), not a binary. And Rust doesn't use the lockfile in this case. Another solution than `cargo vendor` would have been to strictly enforce the version in the top-level Cargo.toml, but it implies to add all the transitive dependencies (as otherwise, when a new transitive dependency is released, cargo will fetch it, making the environment inconsistent). This solution is not viable as the purpose of Cargo.toml is to enforce versions on direct dependencies only, and leave the cargo solver doing its job for the transitive dependencies. For these reasons, the solution of vendoring the dependencies to build the static library has been selected.
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
from
1ba80c6 to
215c7c8
Compare
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
from
215c7c8 to
b2ba551
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
wasm should not use vendor
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
from
c0c0f04 to
0ab8103
Compare
|
!ci-build-me |
|
!ci-build-me |
dannywillems
force-pushed
the
dw/back-on-nightly-for-wasm
branch
from
b133689 to
7d5f961
Compare
svv232
changed the title
|
Closing, old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #16464
nightly has been initially removed as it seemed to make vendoring all the
dependencies more complicated (which seems to not be the case though).
However, removing nightly introduces issues like "DataCloneError", see
o1-labs/o1js#1989, which makes the reliance on
nightly inevitable.
When using wasm-pack with
--offline, we get the following error:I would leave it like this for now, hoping that wasm-pack uses Cargo.lock.
Related o1js and o1js-bindings PR: