RUM Before Send Handler Includes XHR Request Details #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus map. Update secondary timing data extraction to include more request/response info. New function to strip request/response data from payload after the on before send handler has fired.
PanosNB
approved these changes
Nov 28, 2024
| @@ -2,7 +2,7 @@ | |||
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | |||
| <metadata> | |||
| <id>raygun4js</id> | |||
| <version>3.1.2</version> | |||
| <version>3.1.3</version> | |||
There was a problem hiding this comment.
Probably a minor version, not a patch, but I am not being pedantic here, go as is :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the details associated with RUM XHR events to include the original request details. These details are under a new
requestDetailsproperty and they includeurl(with query parameters),method,bodyandresponseBody. Request details are only present in the paylod until theonBeforeSendRUMhandler has been called, after this they're stripped from the payload, so as to not be sent to Raygun's servers. The purpose of this change is to support hydrating certain request details into XHR events, should users wish to do this. As an example, we could now swap out theurlof the xhr event , to be the one fromrequestDetails, so that it includes query parameters in Raygun.