Merge pull request #87 from MindscapeHQ/fix-init-error

Fix raygun4ruby crashing and suppressing app errors if API key is not configured

CHANGELOG.md

@@ -3,3 +3,6 @@
 Features:
   - Added two new configuration options, `filter_payload_with_whitelist` and `whitelist_payload_shape`
     - See [README.md](https://github.com/MindscapeHQ/raygun4ruby#filtering-the-payload-by-whitelist) for an example of how to use them
+
+Bugfixes:
+  - raygun4ruby will no longer crash and suppress app exceptions when the API key is not configured

lib/raygun.rb

@@ -42,6 +42,10 @@ def default_configuration
       configuration.defaults
     end
 
+    def configured?
+      !!configuration.api_key
+    end
+
     def track_exception(exception_instance, env = {})
       if should_report?(exception_instance)
         log("[Raygun] Tracking Exception...")
@@ -71,6 +75,10 @@ def failsafe_log(message)
 
     private
 
+      def print_api_key_warning
+        $stderr.puts(NO_API_KEY_MESSAGE)
+      end
+
       def should_report?(exception)
         return false if configuration.silence_reporting
         return false if configuration.ignore.flatten.include?(exception.class.to_s)

lib/raygun/middleware/rack_exception_interceptor.rb

@@ -9,10 +9,10 @@ def initialize(app)
       def call(env)
         response = @app.call(env)
       rescue Exception => exception
-        Raygun.track_exception(exception, env)
+        Raygun.track_exception(exception, env) if Raygun.configured?
         raise exception
       end
 
     end
   end
-end
+end

lib/raygun/middleware/rails_insert_affected_user.rb

@@ -22,11 +22,10 @@ def call(env)
 
             env["raygun.affected_user"] = { :identifier => identifier }
           end
-
         end
         raise exception
       end
 
     end
   end
-end
+end

lib/raygun/railtie.rb

@@ -1,5 +1,4 @@
 class Raygun::Railtie < Rails::Railtie
-
   initializer "raygun.configure_rails_initialization" do |app|
 
     # Thanks Airbrake: See https://github.com/rails/rails/pull/8624
@@ -34,5 +33,4 @@ class Raygun::Railtie < Rails::Railtie
   rake_tasks do
     load "tasks/raygun.tasks"
   end
-
 end

test/unit/raygun_test.rb

@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-
+require_relative "../test_helper.rb"
+require 'stringio'
+
+class RaygunTest < Raygun::UnitTest
+
+  def test_raygun_is_not_configured_with_no_api_key
+    Raygun.configuration.api_key = nil
+    assert !Raygun.configured?
+  end
+
+end