Profiler totals row should not be part of results. #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code had the chance of removing the profiler-totals when the max traces to show limit is hit, due to the profiler-results with profiler-totals row being the first row.
DropsOfSerenity
changed the title
|
Tested this out and it looks good to me! I set the Before: (badge disappears after fifth trace added) Screencast.from.2025-02-10.15-44-36.webmAfter: (badge stays on the page) Screencast.from.2025-02-10.15-45-57.webm |
|
Thanks! Changelog entry please 🙏 |
@nateberkopec Great! Will add it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code had the chance of removing the profiler-totals when the max traces to show limit is hit, due to the profiler-results with profiler-totals row being the first row.
This would result on the rack mini profiler being unclickable and completely hidden when there are more than max traces to show. Breaking it entirely.
I think theres a bigger discussion about if we can support a way to see all traces, or paginate them in some way. But I think that's for another PR/discussion.