-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move alembic to project root #138
base: main
Are you sure you want to change the base?
Conversation
.idea/dataSources.local.xml
Outdated
@@ -0,0 +1,22 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we git ignore .idea
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will create a new PR to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Mirascope, We don't define the .idea
.
I have deleted the directory.
https://github.com/Mirascope/mirascope/blob/9ef3af7e69d7dbb48ee460a671bf07e47759d551/.gitignore#L164-L169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hmmm...if its useful to keep then we can keep it. I don't use JetBrains so I was not sure.
I went ahead and resolved merge conflicts due to some of my changes, take a look |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
15438009 | Triggered | Generic Private Key | e0f410c | lilypad/ee/free_tier_private_key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Deploying lilypad-website with
|
Latest commit: |
b13b8c0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1b8db73d.lilypad-website-et1.pages.dev |
Branch Preview URL: | https://move-alembic-to-project-root.lilypad-website-et1.pages.dev |
We also need to update main
Remove the cwd, since we are running fastapi in the root of lilypad now |
No description provided.