Fix: Adjust flush timing for nested generations using outermost_lock_context #183
+70
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #176
Overview:
Fix the issue where spans in nested generations are flushed prematurely, causing foreign key constraint failures due to missing parent spans.
Changes:
manual_flush_context()
to outermost_lock_context(). When enabled for the outermost generation (enable_lock=True
),outermost_lock_context()
acquires the BatchSpanProcessor's condition lock (via "with processor.condition:") to synchronize flush operations. This ensures that flush occurs only once at the end of the outermost generation.Effect:
This change ensures that all spans are sent only after the entire nested generation has completed, preserving the parent-child relationships and avoiding foreign key constraint issues.