Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept only integer type values for arguments #16

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

Apaczer
Copy link
Member

@Apaczer Apaczer commented Jul 24, 2024

use [tick] for logo_start & logo_ending read

@TriForceX
Copy link
Member

TriForceX commented Jul 25, 2024

Looks fine to me! i just would change the description:
tick - 1/60th of a second
to:
tick -1 = 60 times per second
first one may confuse some non-english speakers

@Apaczer
Copy link
Member Author

Apaczer commented Jul 27, 2024

Hmm, then it should be "60 ticks per second" or "60 ticks=1 second". Regardless, semantically it should be left as is, I could just use ¹⁄₆₀ character.

@TriForceX
Copy link
Member

yea i was about to wrote 60 times per second, but then "tick - 60 times per second" doesnt look very descriptive 😄, lets leave it as it (1/60th of a second), is nothing very relevant!

@Apaczer Apaczer merged commit 67cf5ac into MiyooCFW:master Jul 27, 2024
2 checks passed
@Apaczer Apaczer deleted the args_upd branch July 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants