Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage of tags in MMG5_swap23 #283

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

coprigent
Copy link
Contributor

This update fixes the way tags are applied to newly created tetras in MMG5_swap23. Several calls of MMG3D_get_shellEdgeTag are added in order to provide complete data to new tetras. These calls must be performed before the call of memcpy function since this call overwrites data about the initial tetra.
This update is motivated by the need to improve the behaviour of parMmg continuous integration tests.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.44%. Comparing base (f6b3408) to head (d97c353).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/mmg3d/swap_3d.c 0.00% 2 Missing ⚠️
src/mmg3d/chkmsh_3d.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #283      +/-   ##
===========================================
- Coverage    50.44%   50.44%   -0.01%     
===========================================
  Files          177      177              
  Lines        47236    47238       +2     
  Branches     10271    10271              
===========================================
  Hits         23830    23830              
- Misses       15674    15676       +2     
  Partials      7732     7732              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane self-requested a review September 24, 2024 12:46
@Algiane Algiane added kind: bug error or fault part: mmg3d mmg3d specific labels Sep 24, 2024
@Algiane Algiane merged commit 8a84488 into MmgTools:develop Sep 24, 2024
25 of 26 checks passed
@coprigent coprigent deleted the feature/pmmg-edge-tag-consistency branch September 24, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug error or fault part: mmg3d mmg3d specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants