Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22143] Introduce FileSizeRange #325

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[DOP-22143] Introduce FileSizeRange #325

merged 1 commit into from
Jan 13, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 13, 2025

Change Summary

Introduce new class FileSizeRange(min=..., max=...).
We haven't reached consensus regarding class name, other possible options are MinFileSize(...) and MaxFileSize(...).

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (dc1bc9a) to head (c3a8469).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
onetl/file/filter/file_size.py 94.73% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #325      +/-   ##
===========================================
+ Coverage    91.67%   91.86%   +0.18%     
===========================================
  Files          225      226       +1     
  Lines         9698     9738      +40     
  Branches       988      994       +6     
===========================================
+ Hits          8891     8946      +55     
+ Misses         612      600      -12     
+ Partials       195      192       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review January 13, 2025 09:41
@dolfinus dolfinus marked this pull request as draft January 13, 2025 09:47
@IlyasDevelopment IlyasDevelopment self-requested a review January 13, 2025 09:54
@dolfinus dolfinus changed the title [DOP-22143] Implement FileSizeFilter [DOP-22143] Introduce FileSizeFilter Jan 13, 2025
@dolfinus dolfinus changed the title [DOP-22143] Introduce FileSizeFilter [DOP-22143] Introduce FileSizeRange Jan 13, 2025
@dolfinus dolfinus marked this pull request as ready for review January 13, 2025 11:26
@dolfinus dolfinus merged commit bf8437c into develop Jan 13, 2025
39 checks passed
@dolfinus dolfinus deleted the feature/DOP-22143 branch January 13, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants