-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-22143] Introduce FileSizeRange #325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-22143
branch
from
January 13, 2025 09:30
854f3a2
to
726ce52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #325 +/- ##
===========================================
+ Coverage 91.67% 91.86% +0.18%
===========================================
Files 225 226 +1
Lines 9698 9738 +40
Branches 988 994 +6
===========================================
+ Hits 8891 8946 +55
+ Misses 612 600 -12
+ Partials 195 192 -3 ☔ View full report in Codecov by Sentry. |
IlyasDevelopment
approved these changes
Jan 13, 2025
dolfinus
force-pushed
the
feature/DOP-22143
branch
from
January 13, 2025 11:04
726ce52
to
c2c2acc
Compare
dolfinus
changed the title
[DOP-22143] Implement FileSizeFilter
[DOP-22143] Introduce FileSizeFilter
Jan 13, 2025
dolfinus
force-pushed
the
feature/DOP-22143
branch
from
January 13, 2025 11:11
c2c2acc
to
9d4da44
Compare
dolfinus
changed the title
[DOP-22143] Introduce FileSizeFilter
[DOP-22143] Introduce FileSizeRange
Jan 13, 2025
dolfinus
force-pushed
the
feature/DOP-22143
branch
from
January 13, 2025 11:13
9d4da44
to
6174840
Compare
dolfinus
force-pushed
the
feature/DOP-22143
branch
from
January 13, 2025 12:43
6174840
to
c3a8469
Compare
IlyasDevelopment
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Introduce new class
FileSizeRange(min=..., max=...)
.We haven't reached consensus regarding class name, other possible options are
MinFileSize(...)
andMaxFileSize(...)
.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)