Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22144] Introduce TotalFilesSize limit #326

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 13, 2025

Change Summary

Introduce TotalFilesSize(...) limit class.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (dc1bc9a) to head (b02ff6e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
onetl/file/limit/total_files_size.py 89.18% 3 Missing and 1 partial ⚠️
onetl/file/limit/max_files_count.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #326      +/-   ##
===========================================
+ Coverage    91.67%   91.83%   +0.15%     
===========================================
  Files          225      226       +1     
  Lines         9698     9746      +48     
  Branches       988      993       +5     
===========================================
+ Hits          8891     8950      +59     
+ Misses         612      603       -9     
+ Partials       195      193       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review January 13, 2025 11:26
@dolfinus dolfinus merged commit 20eb931 into develop Jan 13, 2025
38 of 39 checks passed
@dolfinus dolfinus deleted the feature/DOP-22144 branch January 13, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants