Utf 16 fixes #166
Open
Utf 16 fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt's UTF-8 decoder will decode UTF-16 strings with only low code points as the right string with a null character after each real character, which encodes back to the same data, so the reverse conversion check fails. If there's a BOM, then there's a high code point that won't decode, so this problem was avoided, and only occurred when there was no BOM. QStringConverter::encodingForData returns nullopt if there's no BOM to identify the encoding instead of trying to work it out, so it's safer to guess UTF-16 if there's no identified encoding but there were null bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ModOrganizer2/modorganizer#2209