-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass context to ArgumentType.parse #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incredibly important to merge!!! well implemented, would need that😂
i don't quite get if this is sarcasm or actual comment of approval? |
I am not joking i REALLY NEED THIS NOW PLS |
you can just clobe PR repo and build it from source, doesn't take all that
long
…On Tue, Sep 21, 2021, 21:48 Paul Dietrich ***@***.***> wrote:
this is incredibly important to merge!!! well implemented, would need that
😂
i don't quite get if this is sarcasm or actual comment of approval?
I am not joking i REALLY NEED THIS NOW PLS
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVAGAIZQWYHQIHY4RFDMD3UDDHQFANCNFSM4SRYS5CQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I won't be continuing work on this feature, as there's a lot of complications mentioned in the issue linked in the first post. |
This Pull Request implements the suggestion outlined in #76
It has been implemented to be non-breaking unless an implemented argument type can return a nullable value. Since the CommandContext is not yet available at this point in time, we can pass the command source, from which the required context can usually be extracted.