Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to ArgumentType.parse #77

Closed
wants to merge 4 commits into from

Conversation

Martmists-GH
Copy link

This Pull Request implements the suggestion outlined in #76

It has been implemented to be non-breaking unless an implemented argument type can return a nullable value. Since the CommandContext is not yet available at this point in time, we can pass the command source, from which the required context can usually be extracted.

@ghost
Copy link

ghost commented Oct 15, 2020

CLA assistant check
All CLA requirements met.

Copy link

@DietrichPaul DietrichPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incredibly important to merge!!! well implemented, would need that😂

@lenrik1589
Copy link

this is incredibly important to merge!!! well implemented, would need that😂

i don't quite get if this is sarcasm or actual comment of approval?

@DietrichPaul
Copy link

this is incredibly important to merge!!! well implemented, would need that😂

i don't quite get if this is sarcasm or actual comment of approval?

I am not joking i REALLY NEED THIS NOW PLS

@lenrik1589
Copy link

lenrik1589 commented Sep 21, 2021 via email

@Martmists-GH
Copy link
Author

I won't be continuing work on this feature, as there's a lot of complications mentioned in the issue linked in the first post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants