meta: internal changes

Mojang · Jul 25, 2024 · 42a3d21 · 42a3d21
1 parent 7b0b5ad
commit 42a3d21
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/TODO b/TODO
@@ -43,4 +43,5 @@ TODO:
 * deprecate meta properties in favor of custom data
 * make meta objects safe to use with null nodes
 * natvis for meta_custom
+* meta: vectors for details and props
 * suppress -Wself-move on CI with g++13
diff --git a/src/entt/meta/factory.hpp b/src/entt/meta/factory.hpp
@@ -114,13 +114,13 @@ class basic_meta_factory {
         }
     }
 
-    void custom(const id_type type, std::shared_ptr<void> udata) {
+    void custom(meta_custom_node node) {
         if(bucket == parent) {
-            internal::meta_context::from(*ctx).value[parent].custom = {type, std::move(udata)};
+            internal::meta_context::from(*ctx).value[parent].custom = std::move(node);
         } else if(is_data) {
-            details->data[bucket].custom = {type, std::move(udata)};
+            details->data[bucket].custom = std::move(node);
         } else {
-            details->func[bucket].custom = {type, std::move(udata)};
+            details->func[bucket].custom = std::move(node);
         }
     }
 
@@ -544,7 +544,7 @@ class meta_factory: private internal::basic_meta_factory {
      */
     template<typename Value, typename... Args>
     meta_factory custom(Args &&...args) {
-        base_type::custom(type_id<Value>().hash(), std::make_shared<Value>(std::forward<Args>(args)...));
+        base_type::custom(internal::meta_custom_node{type_id<Value>().hash(), std::make_shared<Value>(std::forward<Args>(args)...)});
         return *this;
     }
 };