Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sys.executable over explicit call to python #451

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

susilehtola
Copy link
Collaborator

@susilehtola susilehtola commented Sep 4, 2024

Description

The psi4 frontend calls python which may not be available or not have psi4.
This PR replaces the call with sys.executable.

closes #450

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! I'm surprised that psi4 is the only one with the call, but I checked.

@loriab loriab merged commit 3a01eb2 into MolSSI:master Jan 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed of psi4 1.9.1 due to qcengine
2 participants