Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: Implement MiniGameLayout, MiniGameCueLayout, KidsModeLayoutAccessor #250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GRAnimated
Copy link
Collaborator

@GRAnimated GRAnimated commented Jan 11, 2025

Implements MiniGameLayout, MiniGameCueLayout, KidsModeLayoutAccessor, and functions in SceneObjUtil. The destructor for ISceneObj has also been moved to match the game's vtable, And no ISceneObj virtual functions are pure virtuals so that's been corrected too. An inlined getSceneObj template function has been added for nicer looking type-casting when getting scene objects.

There's one mismatching function, KidsModeLayoutAccessor::~KidsModeLayoutAccessor, which I can't get to generate the same as the original.


This change is Reviewable

@MonsterDruide1
Copy link
Owner

Should wait for #227 to be merged, which solves the issues regarding ISceneObj destructors.

@MonsterDruide1
Copy link
Owner

Has to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants