Npc: Implement `FukuwaraiFaceParts` #270

GRAnimated · 2025-01-14T23:01:59Z

It's the capture(s) in the picture match room in Mushroom Kingdom. The name Fukuwarai is the original game it was based on.

I looked it up and Nintendo released a Mario Fukuwarai print out that looks pretty similar to SMO's:

Link to the article

Interestingly, that article was created in December of 2016, meaning that this print out predates SMO's minigame. One must have inspired the other.

This change is

…aceParts

MonsterDruide1

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @GRAnimated)

src/Npc/FukuwaraiFaceParts.cpp line 84 at r1 (raw file):

            rotation.y += 360.0f;
        }
        mTargetAngle = y;

Maybe the compiler generated this?

Suggestion:

        if (rotation.y < 0.0f) {
            rotation.y += 360.0f;
        }
        mTargetAngle = rotation.y;

src/Npc/FukuwaraiFaceParts.cpp line 98 at r1 (raw file):

}

s32 calculateFukuwaraiPartPriority(const char* name) {

Does it still match if you do [X]Part.name here instead of hardcoding them again?

src/Npc/FukuwaraiFaceParts.cpp line 151 at r1 (raw file):

            if (al::isMsgPlayerDisregard(message) || rs::isMsgPlayerDisregardHomingAttack(message))
                return true;
        }

Wow. I'm glad they checked the nerve here.

Code quote:

        if (al::isNerve(this, &NrvFukuwaraiFaceParts.Wait)) {
            if (al::isMsgPlayerDisregard(message) || rs::isMsgPlayerDisregardHomingAttack(message))
                return false;
        } else {
            if (al::isMsgPlayerDisregard(message) || rs::isMsgPlayerDisregardHomingAttack(message))
                return true;
        }

src/Npc/FukuwaraiFaceParts.cpp line 219 at r1 (raw file):

            bodyPart = MarioNosePart;
        else
            return -5.0f;

Nice, if the game messes up, you're being punished. Great.

src/Npc/FukuwaraiFaceParts.cpp line 235 at r1 (raw file):

    }

    return bodyPart.a + bodyPart.c * calcScoreAngleRate() + (bodyPart.b * calcScoreDistRate());

This is the only information we have available on a, b and c?

Just for myself: calcScore[X]Rate() returns a value between 0-1, where 1 is "you did good".

src/Npc/FukuwaraiFaceParts.cpp line 250 at r1 (raw file):

        difference = angle - mTargetAngle;
    else
        difference = mTargetAngle - angle;

(or some variation of this)

Suggestion:

    f32 difference = sead::Mathf::abs(angle - mTargetAngle);

src/Npc/FukuwaraiFaceParts.cpp line 255 at r1 (raw file):

    if (al::isEqualString("FukuwaraiMarioNose", al::getModelName(this))) {
        f32 clampedScore = (score > 90.0f) ? 180.0f - score : score;

(same as written above)

Suggestion:

f32 clampedScore = score > 90.0f ? 180.0f - score : score;

src/Npc/FukuwaraiFaceParts.cpp line 257 at r1 (raw file):

        f32 clampedScore = (score > 90.0f) ? 180.0f - score : score;

        return 1.0f - clampedScore / 90.0f;

Ohh, right, you can place the nose upside down - that's clever!

Code quote:

        f32 clampedScore = (score > 90.0f) ? 180.0f - score : score;

        return 1.0f - clampedScore / 90.0f;

src/Npc/FukuwaraiFaceParts.cpp line 270 at r1 (raw file):

    score = sead::Mathf::clamp(score, 0.0f, 1.0f);

    return (1.0f - score) * (1.0f - score);

Suggestion:

return sead::Mathf::square(1.0f - score);

src/Npc/FukuwaraiFaceParts.cpp line 347 at r1 (raw file):

        al::addRotateAndRepeatY(this, -2.0f);
        al::holdSe(this, "Rotate_loop");
    }

Not even custom actions that are not called Jump? Lame.

Code quote:

    if (rs::isHoldHackAction(mIUsePlayerHack)) {
        al::addRotateAndRepeatY(this, 2.0f);
        al::holdSe(this, "RotateRev_loop");
    }
    if (rs::isHoldHackJump(mIUsePlayerHack)) {
        al::addRotateAndRepeatY(this, -2.0f);
        al::holdSe(this, "Rotate_loop");
    }

src/Npc/FukuwaraiFaceParts.cpp line 383 at r1 (raw file):

    if (al::isGreaterStep(this, 30))
        al::setNerve(this, &NrvFukuwaraiFaceParts.CaptureMove);

... that's not a nice way to restart the animation.

src/Npc/FukuwaraiFaceParts.h line 17 at r1 (raw file):

    f32 a;
    f32 b;
    f32 c;

Not happy with these names, we don't get information from any other file, right?

Code quote:

    f32 a;
    f32 b;
    f32 c;

src/Npc/FukuwaraiFaceParts.h line 54 at r1 (raw file):

    f32 mTargetAngle = 0.0f;
    sead::Vector3f mTargetPos = sead::Vector3f::zero;
    al::AreaObjGroup* mAreaObjGroup = nullptr;

(name taken from FukuwaraiWatcher::init)

Suggestion:

al::AreaObjGroup* mFukuwaraiArea = nullptr;

GRAnimated

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @MonsterDruide1)

src/Npc/FukuwaraiFaceParts.h line 17 at r1 (raw file):