-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapObj: Implement TransparentWall
#276
MapObj: Implement TransparentWall
#276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @GRAnimated)
src/Util/ActorDimensionKeeper.h
line 50 at r1 (raw file):
const char* getSpecialPurposeName2DOnly(); al::CollisionPartsFilterOnlySpecialPurpose* createAndSetFilter2DOnly(al::LiveActor* actor);
Suggestion:
void createAndSetFilter2DOnly(al::LiveActor* actor);
src/MapObj/TransparentWall.cpp
line 33 at r1 (raw file):
bool TransparentWall::receiveMsg(const al::SensorMsg* message, al::HitSensor* source, al::HitSensor* target) {
self/other naming convention
Code quote:
bool TransparentWall::receiveMsg(const al::SensorMsg* message, al::HitSensor* source,
al::HitSensor* target) {
src/MapObj/TransparentWall.h
line 11 at r1 (raw file):
virtual void init(const al::ActorInitInfo& info) override; virtual bool receiveMsg(const al::SensorMsg* message, al::HitSensor* source, al::HitSensor* target) override;
Also, receiveMsg
should follow self/other
naming convention (same in cpp)
Suggestion:
void init(const al::ActorInitInfo& info) override;
bool receiveMsg(const al::SensorMsg* message, al::HitSensor* source,
al::HitSensor* target) override;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @MonsterDruide1)
src/MapObj/TransparentWall.h
line 11 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Also,
receiveMsg
should followself/other
naming convention (same in cpp)
Done.
src/MapObj/TransparentWall.cpp
line 33 at r1 (raw file):
Previously, MonsterDruide1 wrote…
self/other naming convention
Done.
src/Util/ActorDimensionKeeper.h
line 50 at r1 (raw file):
const char* getSpecialPurposeName2DOnly(); al::CollisionPartsFilterOnlySpecialPurpose* createAndSetFilter2DOnly(al::LiveActor* actor);
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @GRAnimated)
TransparentWall
TransparentWall
Just a standard invisible wall that you don't see everywhere in the game.
This change is