-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: Fix error outputs for compile-check
#287
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
.github/workflows/compile-check.yml
line 70 at r1 (raw file):
else cat errfile | tr '\n' '\f' | sed 's/Stack backtrace:.*//' | tr '\f' '\n' exit 2
exit 2
can now be changed back to exit 1
since we know where the issue was.
a1dc30a
to
b9e18b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Werechang)
.github/workflows/compile-check.yml
line 70 at r1 (raw file):
Previously, Werechang (Cookieso) wrote…
exit 2
can now be changed back toexit 1
since we know where the issue was.
Good catch - done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @MonsterDruide1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MonsterDruide1)
Fixes #60
So far, the
compile-check
workflow did not output its error messages, becausetools/check
failed with a non-zero exit code in these circumstances, so the remainder of the step would not be executed. By adding|| true
to it, failing return codes are ignored. Additionally, by piping the error to a file and reading it back withcat
, newlines are preserved. Rust shows its stack trace by default when usingbail!
to exit a program, so we're also cutting that and the remainder of the (multiline) message away usingsed
.\f
(form feed symbol) is used as a temporary replacement for\n
here, to allow multi-line replacements insed
without fancy commands.This change is