-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Util: Implement SequentialUtil #301
Util: Implement SequentialUtil #301
Conversation
2c3f9c2
to
700c411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Naii-the-Baf)
src/Util/SequentialUtil.h
line 4 at r1 (raw file):
#include <basis/seadTypes.h> #include <math/seadVector.h>
Useless include
src/Util/SequentialUtil.cpp
line 7 at r1 (raw file):
void rs::convertCsecTo(s32* minutes, s32* seconds, s32* csec, s32 time) { *minutes = time / 6000; *seconds = (time - (time / 6000) * 6000) / 100;
Suggestion:
*seconds = (time % 6000) / 100;
src/Util/SequentialUtil.cpp
line 20 at r1 (raw file):
s32 RaceTimeFunction::clampRaceRecordCsec(s32 csec) { return sead::Mathi::clamp(csec, 0, 359999);
Avoid magic numbers that are already defined once
Suggestion:
return sead::Mathi::clamp(csec, 0, getRaceTimeMaxCsec());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Naii-the-Baf)
src/Util/SequentialUtil.cpp
line 7 at r1 (raw file):
void rs::convertCsecTo(s32* minutes, s32* seconds, s32* csec, s32 time) { *minutes = time / 6000; *seconds = (time - (time / 6000) * 6000) / 100;
Nevermind, saw the decomp.me
on that now - rather keep the match.
700c411
to
2c10a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @MonsterDruide1)
src/Util/SequentialUtil.h
line 4 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Useless include
Done.
src/Util/SequentialUtil.cpp
line 20 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Avoid magic numbers that are already defined once
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Naii-the-Baf)
-- commits
line 0 at r2:
Requires rebase.
2c10a32
to
70e60e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
Previously, MonsterDruide1 wrote…
Requires rebase.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Naii-the-Baf)
Most likely utility functions for koopa freerunning and timers.
This change is