Library/Nature: Implement WaterSurfaceFinder

[MonsterDruide1]

Small helper class to locate the nearest water surface looking down from the given actor. Sadly, because updateLocal is not matching, none of the other functions for updating the result matches either.

https://decomp.me/scratch/zHEdm

---

This change is 

[tetraxile]

unfortunate :( i wasn't able to make it any better either. hopefully someone will figure this out

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)

---

lib/al/Library/Nature/WaterSurfaceFinder.cpp line 17 at r1 (raw file):

// NON_MATCHING: storing {0,0,0} if no surface was found (https://decomp.me/scratch/zHEdm)
void WaterSurfaceFinder::updateLocal(const sead::Vector3f& position, const sead::Vector3f& gravity,
                                     f32 distance, bool flat, bool displacement, bool overGround) {

should these names begin with an is? as in, isFlat, isDisplacement, isOverGround?

[MonsterDruide1]

As this example is pretty isolated, I could also do

__asm("add x8, x19, #0xc");
__asm("str wzr, [x8, #0x18]");
__asm("str xzr, [x8]");
__asm("stp xzr, xzr, [x8, #8]");

... but honestly, I prefer mismatching a couple of functions rather than introducing stuff like that.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tetraxile)

---

lib/al/Library/Nature/WaterSurfaceFinder.cpp line 17 at r1 (raw file):

Previously, tetraxile wrote…

should these names begin with an is? as in, isFlat, isDisplacement, isOverGround?

Yes, that sounds better - also renamed distance => maxDistance, while we're at it.

[tetraxile]

yeah, i'd agree. i think it's a slippery slope once you start doing things like that, and it defeats the purpose of the decomp.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MonsterDruide1)