Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System: Implement SphinxQuizData #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Naii-the-Baf
Copy link
Contributor

@Naii-the-Baf Naii-the-Baf commented Jan 30, 2025

Data object for answers for the Sphinx's questions.


This change is Reviewable

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Naii-the-Baf)


src/System/SphinxQuizData.cpp line 19 at r1 (raw file):

            mIsAnswerCorrectSphinxQuizAll[i] = false;
        }
    }

That initial size check is auto-generated by the compiler.

Suggestion:

    for (s64 i = 0; i < mArraySize; i++) {
        mIsAnswerCorrectSphinxQuiz[i] = false;
        mIsAnswerCorrectSphinxQuizAll[i] = false;
    }

src/System/SphinxQuizData.cpp line 39 at r1 (raw file):

void SphinxQuizData::write(al::ByamlWriter* writer) {
    for (s64 i = 0; i < mArraySize; i++) {

Suggestion:

for (s32 i = 0; i < mArraySize; i++) {

src/System/SphinxQuizData.cpp line 50 at r1 (raw file):

    init();

    for (s64 i = 0; i < mArraySize; i++) {

Suggestion:

for (s32 i = 0; i < mArraySize; i++) {

Copy link
Contributor Author

@Naii-the-Baf Naii-the-Baf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @MonsterDruide1)


src/System/SphinxQuizData.cpp line 19 at r1 (raw file):

Previously, MonsterDruide1 wrote…

That initial size check is auto-generated by the compiler.

Done.


src/System/SphinxQuizData.cpp line 39 at r1 (raw file):

void SphinxQuizData::write(al::ByamlWriter* writer) {
    for (s64 i = 0; i < mArraySize; i++) {

Done.


src/System/SphinxQuizData.cpp line 50 at r1 (raw file):

    init();

    for (s64 i = 0; i < mArraySize; i++) {

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants