Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library/MapObj: Implement WheelMapParts #325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fuzzy2319
Copy link
Contributor

@Fuzzy2319 Fuzzy2319 commented Jan 31, 2025

This PR:

  • adds WheelMapParts functions.
  • adds WheelMovement ctor

This change is Reviewable

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Fuzzy2319)


lib/al/Library/Movement/WheelMovement.cpp line 21 at r1 (raw file):

    _10 = _20;

    sead::Vector3f local_80 = sead::Vector3f::ex;

Suggestion:

sead::Vector3f localRotateAxis = sead::Vector3f::ex;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants