Library/LiveActor: Implement actor SensorMsg related functions
#415
+2,351
−914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements most of the
SensorMsgpart ofActorSensorMsgUtil, increasing the matching percentage to10.489%(1.21%increase).Some of the macros are a bit messy due to restrictions in the c++ pre-processor, but the stuff like
_ = nullptr, don't affect the compiled code. Some things I added to the macros are also not used yet, but are meant for a later PR that implements gameSensorMsgs, they might also be useful for mods.Now that the
alsendMsgandisMsgfunctions are matching,tools/checkis able to detect if implemented functions are using the wrong ones. This caused a few mismatches on old functions, which I fixedThis PR is blocked by #370
This change is