-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to run container as non-root user and other security updates #4
Open
m4rc77
wants to merge
6
commits into
MorbZ:master
Choose a base branch
from
m4rc77:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
284f1a9
Update to run container as non-root user for security reasons. Update…
4353b86
Update README.md
4648927
Update README.md
m4rc77 9b2259e
Update README.md
m4rc77 41958fa
Updated readme; fixes usage of port 8080 with jwilder/nginx-proxy
herrfinke c9d5968
Merge pull request #1 from herrfinke/master
m4rc77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
FROM nginx:1.15-alpine | ||
FROM nginx:1.17-alpine | ||
|
||
COPY start.sh /usr/local/bin/ | ||
|
||
RUN apk add --update bash \ | ||
&& rm -rf /var/cache/apk/* \ | ||
&& chmod -R g+w /var/cache/nginx /var/log/nginx /etc/nginx \ | ||
&& chown -R nginx:root /var/cache/nginx /var/log/nginx /etc/nginx \ | ||
&& chmod g+w /run \ | ||
&& sed -i 's/user nginx;//g' /etc/nginx/nginx.conf \ | ||
&& chmod +x /usr/local/bin/start.sh | ||
|
||
EXPOSE 80 | ||
EXPOSE 8080 | ||
|
||
USER 1000 | ||
|
||
CMD ["start.sh"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question. Even if you switched to a non-root user here, wouldn't nginx still be running as root in the background?
My point is: if an attacker finds a way to exploit nginx he will be root.
To avoid this: a new non-root user must be created and add
user nonroot_username;
in nginx conf so that nginx is not run as root too :)