-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wip): declare exports as separate variables #59
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I wrote comments but then forgot to actually send them 🤦♀️
So here go a bunch of nitpick suggestions, and at least one actual question
<Route | ||
render={({ location }) => ( | ||
<Routes location={location}> | ||
<Route | ||
// pathId - URL param for directly accessing particular path. | ||
path='/:pathId?' | ||
path='/:pathId? ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do we need the space here for?
@@ -1,22 +1,23 @@ | |||
import ContributionResources from "."; | |||
// import index from "./index"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required? if not can we remove it?
@@ -17,3 +17,5 @@ export default { | |||
gooey: 'Conventions help a lot to keep code readable, even if many different people contribute to it. For what would you like to see our conventions?', | |||
}, | |||
}; | |||
|
|||
export default Convention; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default Convention; | |
export default Convention; | |
}; | ||
|
||
export default Git; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default Git; | |
export default Git; | |
// name: 'Done. What else should I know about?', | ||
// child: index, | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
@@ -25,3 +25,5 @@ export default { | |||
gooey: 'What type of art would you like to contribute?', | |||
}, | |||
}; | |||
|
|||
export default index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default index; | |
export default index; | |
}; | ||
|
||
export default Contact; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default Contact; | |
export default Contact; | |
@@ -31,3 +31,5 @@ export default { | |||
gooey: 'So I heard you want to contribute? Tell me who you are and I tell you where to go.', | |||
}, | |||
}; | |||
|
|||
export default Contributor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default Contributor; | |
export default Contributor; | |
@@ -17,3 +17,5 @@ export default { | |||
gooey: 'What would you like to design?', | |||
}, | |||
}; | |||
|
|||
export default index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default index; | |
export default index; | |
}; | ||
|
||
export default Architechture; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default Architechture; | |
export default Architechture; | |
No description provided.