Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wip): declare exports as separate variables #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

majordwarf
Copy link
Member

No description provided.

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I wrote comments but then forgot to actually send them 🤦‍♀️
So here go a bunch of nitpick suggestions, and at least one actual question

<Route
render={({ location }) => (
<Routes location={location}>
<Route
// pathId - URL param for directly accessing particular path.
path='/:pathId?'
path='/:pathId? '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we need the space here for?

@@ -1,22 +1,23 @@
import ContributionResources from ".";
// import index from "./index";
Copy link
Member

@jdrueckert jdrueckert Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still required? if not can we remove it?

@@ -17,3 +17,5 @@ export default {
gooey: 'Conventions help a lot to keep code readable, even if many different people contribute to it. For what would you like to see our conventions?',
},
};

export default Convention;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Convention;
export default Convention;

};

export default Git;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Git;
export default Git;

Comment on lines +13 to +16
// name: 'Done. What else should I know about?',
// child: index,
// },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

@@ -25,3 +25,5 @@ export default {
gooey: 'What type of art would you like to contribute?',
},
};

export default index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default index;
export default index;

};

export default Contact;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Contact;
export default Contact;

@@ -31,3 +31,5 @@ export default {
gooey: 'So I heard you want to contribute? Tell me who you are and I tell you where to go.',
},
};

export default Contributor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Contributor;
export default Contributor;

@@ -17,3 +17,5 @@ export default {
gooey: 'What would you like to design?',
},
};

export default index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default index;
export default index;

};

export default Architechture;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Architechture;
export default Architechture;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants