Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #2656 Fix tabs scrollbar refreshing issue #2941

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fixes #2656 Fix tabs scrollbar refreshing issue #2941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/TabsWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,10 @@ private void enterSelectMode() {
mSelecting = true;
mSelectTabsButton.setVisibility(View.GONE);
mDoneButton.setVisibility(View.VISIBLE);
mAdapter.notifyDataSetChanged();
updateSelectionMode();
mWidgetManager.pushBackHandler(mSelectModeBackHandler);

post(() -> mAdapter.notifyDataSetChanged());
}

private void exitSelectMode() {
Expand All @@ -336,9 +337,10 @@ private void exitSelectMode() {
mSelectTabsButton.setVisibility(View.VISIBLE);
mDoneButton.setVisibility(View.GONE);
mSelectedTabs.clear();
mAdapter.notifyDataSetChanged();
updateSelectionMode();
mWidgetManager.popBackHandler(mSelectModeBackHandler);

post(() -> mAdapter.notifyDataSetChanged());
}

private void updateSelectionMode() {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/tabs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
android:paddingStart="15dp"
android:paddingEnd="15dp"
android:layout_marginTop="10dp"
android:layout_marginBottom="5dp"
android:layout_marginBottom="10dp"
android:fadingEdgeLength="50dp">
</org.mozilla.vrbrowser.ui.views.CustomRecyclerView>

Expand Down