Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Do not resume compositor when WebVR is exited after suspending the app #3048

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Do not resume compositor when WebVR is exited after suspending the app #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,8 +969,11 @@ void resumeGeckoViewCompositor() {
GleanMetricsService.stopImmersive();
Handler handler = new Handler(Looper.getMainLooper());
handler.postDelayed(() -> {
mWindows.resumeCompositor();
Log.d(LOGTAG, "Compositor Resumed");
if (!mWindows.isPaused()) {
Log.d(LOGTAG, "Compositor resume begin");
mWindows.resumeCompositor();
Log.d(LOGTAG, "Compositor resume end");
}
Comment on lines +972 to +976
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These logs should probably use the LOGTAG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}, 20);
}

Expand Down
4 changes: 4 additions & 0 deletions app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/Windows.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,10 @@ public void onResume() {
TelemetryWrapper.resetOpenedWindowsCount(mPrivateWindows.size(), true);
}

public boolean isPaused() {
return mIsPaused;
}

public void onDestroy() {
if (mTabsWidget != null && !mTabsWidget.isReleased()) {
mTabsWidget.releaseWidget();
Expand Down