Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

l10n string updates #3174

Merged
merged 9 commits into from
Apr 20, 2020
Merged

l10n string updates #3174

merged 9 commits into from
Apr 20, 2020

Conversation

keianhzo
Copy link
Contributor

l10n string updates. Related to mozilla-l10n/android-l10n#192

@keianhzo keianhzo self-assigned this Apr 16, 2020
@keianhzo
Copy link
Contributor Author

@flodolo please help review.

Copy link

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. What about @Pike idea to use CDATA for the string with HTML?

app/src/main/res/values-da/strings.xml Outdated Show resolved Hide resolved
@keianhzo
Copy link
Contributor Author

@flodolo I've updated the PR. I've added an issue to move html encoded entities to CDATA if that plays better with the localization flow: #3185

Copy link

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this, and look into the CDATA later.

@keianhzo
Copy link
Contributor Author

@bluemarvin This is ready to be landed.

@bluemarvin bluemarvin merged commit cc207c7 into master Apr 20, 2020
@bluemarvin bluemarvin deleted the v10/L10n_updates branch April 20, 2020 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants