Fix not throttled events and errors when pointing the remote on the background.

app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java

@@ -109,6 +109,7 @@ public void run() {
     LinkedList<UpdateListener> mWidgetUpdateListeners;
     LinkedList<PermissionListener> mPermissionListeners;
     LinkedList<FocusChangeListener> mFocusChangeListeners;
+    LinkedList<WorldClickListener> mWorldClickListeners;
     LinkedList<Runnable> mBackHandlers;
     private boolean mIsPresentingImmersive = false;
     private Thread mUiThread;
@@ -139,6 +140,7 @@ protected void onCreate(Bundle savedInstanceState) {
         mWidgetUpdateListeners = new LinkedList<>();
         mPermissionListeners = new LinkedList<>();
         mFocusChangeListeners = new LinkedList<>();
+        mWorldClickListeners = new LinkedList<>();
         mBackHandlers = new LinkedList<>();
 
         mWidgets = new HashMap<>();
@@ -192,6 +194,11 @@ protected void initializeWorld() {
 
         // Empty widget just for handling focus on empty space
         mRootWidget = new RootWidget(this);
+        mRootWidget.setClickCallback(() -> {
+            for (WorldClickListener listener: mWorldClickListeners) {
+                listener.onWorldClick();
+            }
+        });
 
         // Create Tray
         mTray = new TrayWidget(this);
@@ -707,6 +714,19 @@ public void removeFocusChangeListener(FocusChangeListener aListener) {
         mFocusChangeListeners.remove(aListener);
     }
 
+
+    @Override
+    public void addWorldClickListener(WorldClickListener aListener) {
+        if (!mWorldClickListeners.contains(aListener)) {
+            mWorldClickListeners.add(aListener);
+        }
+    }
+
+    @Override
+    public void removeWorldClickListener(WorldClickListener aListener) {
+        mWorldClickListeners.remove(aListener);
+    }
+
     @Override
     public void pushBackHandler(Runnable aRunnable) {
         mBackHandlers.addLast(aRunnable);

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/RootWidget.java

@@ -5,6 +5,7 @@
 import android.view.View;
 
 public class RootWidget extends UIWidget {
+    private Runnable mOnClickCallback;
 
     public RootWidget(Context aContext) {
         super(aContext);
@@ -23,19 +24,24 @@ public RootWidget(Context aContext, AttributeSet aAttrs, int aDefStyle) {
 
     @Override
     protected void initializeWidgetPlacement(WidgetPlacement aPlacement) {
-
+        aPlacement.width = 8;
+        aPlacement.height = 8;
     }
 
     private void initialize(Context aContext) {
         setFocusable(true);
         setSoundEffectsEnabled(false);
 
-        setOnClickListener(new OnClickListener() {
-            @Override
-            public void onClick(View v) {
-                requestFocus();
-                requestFocusFromTouch();
+        setOnClickListener(v -> {
+            requestFocus();
+            requestFocusFromTouch();
+            if (mOnClickCallback != null) {
+                mOnClickCallback.run();
             }
         });
     }
+
+    public void setClickCallback(Runnable aRunnable) {
+        mOnClickCallback = aRunnable;
+    }
 }

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WidgetManagerDelegate.java

@@ -15,6 +15,10 @@ interface PermissionListener {
     interface FocusChangeListener {
         void onGlobalFocusChanged(View oldFocus, View newFocus);
     }
+    interface WorldClickListener {
+        // Indicates that the user has clicked on the world, outside of any UI widgets
+        void onWorldClick();
+    }
     int newWidgetHandle();
     void addWidget(@NonNull Widget aWidget);
     void updateWidget(@NonNull Widget aWidget);
@@ -36,6 +40,8 @@ interface FocusChangeListener {
     void removeFocusChangeListener(@NonNull FocusChangeListener aListener);
     void addPermissionListener(PermissionListener aListener);
     void removePermissionListener(PermissionListener aListener);
+    void addWorldClickListener(WorldClickListener aListener);
+    void removeWorldClickListener(WorldClickListener aListener);
     boolean isPermissionGranted(@NonNull String permission);
     void requestPermission(@NonNull String uri, @NonNull String permission, GeckoSession.PermissionDelegate.Callback aCallback);
 }

app/src/main/cpp/BrowserWorld.cpp

@@ -359,7 +359,7 @@ BrowserWorld::State::UpdateControllers(bool& aRelayoutWidgets) {
       VRBrowser::HandleMotionEvent(0, controller.index, pressed, 0.0f, 0.0f);
       controller.widget = 0;
 
-    } else {
+    } else if (wasPressed != pressed) {
       VRBrowser::HandleMotionEvent(0, controller.index, pressed, 0.0f, 0.0f);
     }
     controller.lastButtonState = controller.buttonState;