-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update replicate setup #103
base: master
Are you sure you want to change the base?
Conversation
…al rendered audio, and csv in chord mode
Huge thank you for putting this fix together. I'm using https://replicate.com/e7mac/omnizart and it just works |
Hi @e7mac, Thanks for looking into the Replicate issue! |
@yoyololicon The TF version definitely needs an update. IIRC, it might work with TF v2.8.0+ but wouldn't work at v2.5.0 |
If so, I suggest opening a separate PR for updating the dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a quick review. I see you changed the predict function to render midi as an option.
Is there a feature request for it? Please link it.
If not, please elaborate on the need for it.
- pip install pyfluidsynth | ||
- pip install git+https://github.com/e7mac/omnizart.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to revert this after the dependency update PR.
This PR bumps the dependencies to get the library working on Replicate
It also updates the prediction function to provide the midi output, and the csv output for chord transcription