Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update replicate setup #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

e7mac
Copy link

@e7mac e7mac commented Aug 18, 2023

This PR bumps the dependencies to get the library working on Replicate
It also updates the prediction function to provide the midi output, and the csv output for chord transcription

@vpavlenko
Copy link

Huge thank you for putting this fix together. I'm using https://replicate.com/e7mac/omnizart and it just works

@yoyolicoris
Copy link
Member

Hi @e7mac,

Thanks for looking into the Replicate issue!
Could this PR also work without upgrading the tf version? This causes dependency errors in the CI.
I'll have a proper look after it passes the check.

@yoyolicoris yoyolicoris self-requested a review September 4, 2023 15:20
@e7mac
Copy link
Author

e7mac commented Sep 5, 2023

@yoyololicon The TF version definitely needs an update. IIRC, it might work with TF v2.8.0+ but wouldn't work at v2.5.0

@yoyolicoris
Copy link
Member

yoyolicoris commented Sep 5, 2023

If so, I suggest opening a separate PR for updating the dependency.
Updating to 2.13 might work for Replicate. But not for the origin package, as it failed the integration check.
(Correct me if I'm wrong, not familiar with Replicate.)
We can merge this after solving the dependency issue.

Copy link
Member

@yoyolicoris yoyolicoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick review. I see you changed the predict function to render midi as an option.
Is there a feature request for it? Please link it.
If not, please elaborate on the need for it.

- pip install pyfluidsynth
- pip install git+https://github.com/e7mac/omnizart.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revert this after the dependency update PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants