-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android updates #2206
Open
geneticdrift
wants to merge
14
commits into
MusicPlayerDaemon:master
Choose a base branch
from
geneticdrift:android-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Android updates #2206
geneticdrift
wants to merge
14
commits into
MusicPlayerDaemon:master
from
geneticdrift:android-updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What are these |
16e3545
to
d2df287
Compare
…NAL_STORAGE, added permission READ_MEDIA_AUDIO Change fo r SDK version 33 and above
…ationale is false Android will ignore permission request and will not show the request dialog if the user's action implies "don't ask again." This leaves the app in a crippled state and the user confused. Google says "don't try to convince the user", so it returns false for `shouldShowRequestPermissionRationale`. To help the user proceed, we show the `Request permission` button only if `shouldShowRequestPermissionRationale == true` because there's a good chance the premission request dialog will not be ignored. If `shouldShowRequestPermissionRationale == false` we instead show the "rationale" message and a button to open the app info dialog where the user can explicitly grand the permission.
…eprecated Icons.Default.List
Changed to compatible versions according to https://developer.android.com/jetpack/androidx/releases/compose-kotlin#kts
45cb098
to
034bcf4
Compare
For easier management of dependencies versions: https://developer.android.com/build/migrate-to-catalogs
…nd x86_64 versions of libmpd.so
….loadLibrary("mpd") failure
… and service. Loader converted from java to kotlin. Instead of loading libmpd when the service thread is started, the service will not start the the thread if libmpd failed to load. The loader is also accessed by the view data to let the ui adjust if failed to load, by showing the failure reason and disabling the Start MPD button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.