Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Use more native types in the tests #1373

Merged
merged 1 commit into from
Nov 10, 2024
Merged

[TASK] Use more native types in the tests #1373

merged 1 commit into from
Nov 10, 2024

Conversation

oliverklee
Copy link
Contributor

All glory to the Rector!

@oliverklee oliverklee added this to the 8.0.0 milestone Nov 10, 2024
@oliverklee oliverklee requested a review from JakeQZ November 10, 2024 18:48
@oliverklee oliverklee self-assigned this Nov 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.062%. remained the same
when pulling c75af9f on cleanup/test-types
into 9e25e83 on main.

JakeQZ
JakeQZ approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are quite sharp finds. I wonder if internally it uses the same analysis engine as PHPStan or Psalm - both of which seem like they could be enhanced to apply suggested fixes in some cases.

@JakeQZ JakeQZ merged commit 47fd5db into main Nov 10, 2024
29 checks passed
@JakeQZ JakeQZ deleted the cleanup/test-types branch November 10, 2024 22:49
@oliverklee
Copy link
Contributor Author

I wonder if internally it uses the same analysis engine as PHPStan or Psalm

Yes, it does - Rector has PHPStan as a dependency: https://packagist.org/packages/rector/rector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ