-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #104 - Padatious intent and tracker list #112
Conversation
Reported as working by @robertsawko here |
@Tony763 how do we test this? |
Sadly, VK test did not catch this, as intent worked for it. Only hint about something be wrong was wrote into log and I missed it: skill-homeassistant/70/mycroft/skills.log Lines 333 to 362 in 6cd0965
|
VK tests can be seen there: https://mycroftai.github.io/skill-homeassistant/70/ |
I will rebase this with latest merged commits, so CI can check this, tonight. |
8e6120b
to
28172c2
Compare
@stratus-ss or @krisgesling Could You add “Secure” label? I just rebased this PR to contain latest changes from 20.08 branch (CI should now work). |
28172c2
to
1fa049c
Compare
Rebased, CI run in my repo was successful. |
Allure tests Ok, skill log OK, ready to go 🚀 |
Description
PR contain workaround fixing #104 proposed by @zeronounours.
Proper fix (new functions) is awaiting approve/merge of PR #3101.
As we want to update HA skill in Marketplace, it's better to use this workaround as proper fix can be incorporated later when PR is merged and new Mycroft Core is released.
Credit goes to @zeronounours. Thanks mate.
Fixes #64
Type of PR