mlogan sync 1.42 #21122
Closed
mlogan sync 1.42 #21122
+415
−567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mystenmark
commented
Feb 6, 2025
mystenmark
commented
- Sending to the subscription handler should not block execution
- Make transaction execution sync
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Subscriptions are already not 100% reliable, and this allows a slow subscription handler to block execution indefinitely, which we don't want.
This requires changing MutexTable to be sync, which in turn ripples out into making a few other pieces of code sync, but the blast radius is pretty well contained. I do not expect this to have any significant performance impacts, because most of the previous await points were probably "fake" in that they were unlikely to actually yield execution.
mystenmark
force-pushed
the
mlogan-sync-1.42
branch
from
36a5269 to
69d1473
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.