[Package management] add implicit system package dependencies (dvx-197) #21204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
changed the base branch from
main
to
mdgeorge/framework-version-move
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
github-actions
bot
added
the
Type: Documentation
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
changed the base branch from
mdgeorge/framework-version-move
to
main
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
github-actions
bot
removed
the
Type: Documentation
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
reviewed
Feb 19, 2025
amnn
reviewed
Feb 19, 2025
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
commented
Feb 20, 2025
mdgeorge4153
commented
Feb 20, 2025
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
added a commit
that referenced
this pull request
Mar 8, 2025
…#21383) ## Description This PR adds support for implicit dependencies to the package management at the move layer. ## PR stack #21204 Add implicit Sui dependencies #21384 Refactors to BuildConfig #21383 Add support for implicits to move package management This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356 ## Test plan See `test_sources/implicits/README.md` for a description of the new snapshot tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
mdgeorge4153
force-pushed
the
mdgeorge/build-config-refactors
branch
from
eeee9fd to
bf334c4
Compare
mdgeorge4153
force-pushed
the
mdgeorge/implicit-framework-dep-2
branch
from
d616f25 to
70fa81b
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
force-pushed
the
mdgeorge/implicit-framework-dep-2
branch
from
70fa81b to
a75dc62
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
added a commit
that referenced
this pull request
Mar 9, 2025
## Description This removes `sui_move_build::BuildConfig::default` and makes other small changes ## PR stack #21204 Add implicit Sui dependencies #21384 Refactors to BuildConfig #21383 Add support for implicits to move package management This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356 ## Test plan This disables two broken bytecode verification tests. See DVX-786 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
mdgeorge4153
force-pushed
the
mdgeorge/implicit-framework-dep-2
branch
from
c7f260e to
0b09c9b
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
force-pushed
the
mdgeorge/implicit-framework-dep-2
branch
from
0b09c9b to
4193fc3
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…mplicit dependencies
mdgeorge4153
force-pushed
the
mdgeorge/implicit-framework-dep-2
branch
from
4193fc3 to
6450611
Compare
mdgeorge4153
deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables you to use system packages (e.g.
MoveStdlib,Sui,DeepBook) without explicitly adding them to yourMove.toml. It works by querying the network during publication / upgrade for the protocol version and using that information to determine the correct version of the system dependencies. During build, the latest known version is used.PR stack
#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management
This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356
Test plan
Additional shell tests were added. Since these features are dependent on the protocol version of the network they are interacting with, some of these shell tests communicate with devnet, testnet, and mainnet (as well as localnet).
Some care was also taken to add explicit system dependencies to existing tests so that they would not start using this feature. I think in the future we should think more carefully about how we want to use implicit dependencies in tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.