-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support zh_CN translate #154
Conversation
Thanks for the PR. Is there any reason why we should move from |
Because when linkcheck starts up, the entire service freezes, but switching to linkcheck2 solves the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all your work on this, @lispking! I think this setup works well. Maybe @halfprice can skim the translations to see if they make sense.
We will also have to do some follow-up work, which I will add to #150.
@mlegner Could you please help take a look at the permission error in the CI? It might require your assistance to handle it. /usr/bin/git push --porcelain ***github.com/MystenLabs/walrus-docs.git github-pages-deploy-action/92pjzw8fk:gh-pages
remote: Permission to MystenLabs/walrus-docs.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/MystenLabs/walrus-docs.git/': The requested URL returned error: 403
Changes committed to the gh-pages branch… 📦
Running post deployment cleanup jobs… 🗑️
/usr/bin/git checkout -B github-pages-deploy-action/92pjzw8fk
Reset branch 'github-pages-deploy-action/92pjzw8fk'
/usr/bin/chmod -R +rw github-pages-deploy-action-temp-deployment-folder
/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force
Completed deployment successfully! ✅
Run echo "url=https://mystenlabs.github.io/walrus-docs/pr-preview/pr-154/" >> $GITHUB_OUTPUT
Run marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31
Error: Resource not accessible by integration |
We have a workflow to deploy previews of the PRs, which unfortunately doesn't work from forks. This can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly scan through the translation and spot checked a few places. The translation makes sense to me. Just two nits:
- sliver are used as
sliver
or切片
in different places. May as well to keep it consistent and only usesliver
everywhere. - publisher is translated to
发布者
but I feel发布器
is probably closer to what it is. Also inline with聚合器
.
@halfprice Thanks for the help from the expert in reviewing. It has been corrected, thank you. |
Closes #150