Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zh_CN translate #154

Merged
merged 15 commits into from
Oct 31, 2024
Merged

feat: support zh_CN translate #154

merged 15 commits into from
Oct 31, 2024

Conversation

lispking
Copy link
Contributor

@lispking lispking commented Oct 29, 2024

Closes #150

@mlegner
Copy link
Collaborator

mlegner commented Oct 29, 2024

Thanks for the PR. Is there any reason why we should move from linkcheck to linkcheck2? Also, the linkcheck is not required to build the docs as it is marked as optional.

@lispking
Copy link
Contributor Author

Because when linkcheck starts up, the entire service freezes, but switching to linkcheck2 solves the problem.

@lispking lispking changed the title update: add mdbook-linkcheck2 install to README.md feat: support zh_CN translate Oct 29, 2024
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all your work on this, @lispking! I think this setup works well. Maybe @halfprice can skim the translations to see if they make sense.

We will also have to do some follow-up work, which I will add to #150.

TRANSLATING.md Outdated Show resolved Hide resolved
book.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lispking
Copy link
Contributor Author

@mlegner Could you please help take a look at the permission error in the CI? It might require your assistance to handle it.

/usr/bin/git push --porcelain ***github.com/MystenLabs/walrus-docs.git github-pages-deploy-action/92pjzw8fk:gh-pages
remote: Permission to MystenLabs/walrus-docs.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/MystenLabs/walrus-docs.git/': The requested URL returned error: 403
Changes committed to the gh-pages branch… 📦
Running post deployment cleanup jobs… 🗑️
/usr/bin/git checkout -B github-pages-deploy-action/92pjzw8fk
Reset branch 'github-pages-deploy-action/92pjzw8fk'
/usr/bin/chmod -R +rw github-pages-deploy-action-temp-deployment-folder
/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force
Completed deployment successfully! ✅
Run echo "url=https://mystenlabs.github.io/walrus-docs/pr-preview/pr-154/"  >> $GITHUB_OUTPUT
Run marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31
Error: Resource not accessible by integration

@mlegner
Copy link
Collaborator

mlegner commented Oct 30, 2024

@mlegner Could you please help take a look at the permission error in the CI? It might require your assistance to handle it.

We have a workflow to deploy previews of the PRs, which unfortunately doesn't work from forks. This can be ignored.

Copy link

@halfprice halfprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly scan through the translation and spot checked a few places. The translation makes sense to me. Just two nits:

  • sliver are used as sliver or 切片 in different places. May as well to keep it consistent and only use sliver everywhere.
  • publisher is translated to 发布者 but I feel 发布器 is probably closer to what it is. Also inline with 聚合器.

@lispking
Copy link
Contributor Author

lispking commented Oct 31, 2024

I quickly scan through the translation and spot checked a few places. The translation makes sense to me. Just two nits:

  • sliver are used as sliver or 切片 in different places. May as well to keep it consistent and only use sliver everywhere.
  • publisher is translated to 发布者 but I feel 发布器 is probably closer to what it is. Also inline with 聚合器.

@halfprice Thanks for the help from the expert in reviewing. It has been corrected, thank you.

@mlegner mlegner merged commit 634c9ca into MystenLabs:main Oct 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate to other languages, particularly Chinese
3 participants