-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw data filter regex and task #294
Open
paridhi-parajuli
wants to merge
5
commits into
feature/automate-to-cog-transformation
Choose a base branch
from
automated-transformation/add-raw-data-filter
base: feature/automate-to-cog-transformation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add raw data filter regex and task #294
paridhi-parajuli
wants to merge
5
commits into
feature/automate-to-cog-transformation
from
automated-transformation/add-raw-data-filter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we increase the run per DAG to like 20? |
amarouane-ABDELHAK
approved these changes
Feb 5, 2025
2. Make xcom to pass the s3 location of discovered files rather than the list itself 3. Do chunking for writing the files to s3 if its more than 900
@@ -5,6 +5,9 @@ | |||
from airflow.models.param import Param | |||
from airflow.operators.dummy_operator import DummyOperator | |||
from slack_notifications import slack_fail_alert | |||
from airflow.models.variable import Variable | |||
from dags.veda_data_pipeline.utils.xcom_to_s3 import write_xcom_to_s3,read_xcom_from_s3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import shouldn't work! try
from veda_data_pipeline.utils.xcom_to_s3 import write_xcom_to_s3,read_xcom_from_s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need an additional task to filter the discovered files for cases when we need to select specific subfolders or files within the provided prefix.
Changes:
process_files
Example scenario:
We want the subfolders
/178
/179
and, within that just/00
and only the files withMC02