-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ILAMB example #109
Add ILAMB example #109
Conversation
Checking out v2.7 from github (matches what is used on glade/campaign, except currently missing some CLM-specific scripts)
Process: cd examples/ilamb qinteractive -l select=1:ncpus=16:mpiprocs=16:mem=100G conda activate cupid-analysis ./test_run.sh
From the commit log for de42ba2: cd examples/ilamb
qinteractive -l select=1:ncpus=16:mpiprocs=16:mem=100G
conda activate cupid-analysis
./test_run.sh will run, but every line of output mentions
I'd like to improve how we specify where the output is located (maybe auto-generate |
Pointing to source data on campaign, so this example requires being on an NCAR system. Hopefully we can generalize this in a way to allow users to specify where their data is (perhaps softlinks in ilamb_aux/?)
as of 59f1507 this example is actually running ILAMB, so the one hour walltime is probably insufficient. The script TSS / LMWG folks run uses 12:00:00, so maybe we should do cd examples/ilamb
qinteractive -l select=1:ncpus=16:mpiprocs=16:mem=100G -l walltime=12:00:00
conda activate cupid-analysis
./test_run.sh |
Just a note-- In attempting to check the walltime this uses, I'm getting a bunch of |
A couple of notes from our meeting that are relevant to this PR (should probably be done in this PR; could also merge this PR as a proof of concept and then add an issue ticket for these items):
For debugging ILAMB, it will be useful to delete the bld directory and try restarting. We want to ensure that we're using Keith's ILAMB LMWG version. The main ILAMB also doesn't have CLM specific config files-- they may want to add these in, though. Keith's branch should eventually get brought back in to the main ILAMB repo, but this may take a while still so we are temporarily sticking with Keith's branch. |
This version is now working as far as running ILAMB. The aforementioned features should still be implemented. |
This new issue ticket includes details for automatically updating the configuration files once CUPiD is set up to run from the CESM workflow. For now, we'd like to merge this in as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnlevy1981 I'll let you review this / merge it in, but since you actually opened the PR I think you can't be a reviewer...
Yeah, github won't let me give this a green check but I think it looks great (and #115 highlights what's missing so we can improve on the implementation in the future). |
Update
(cupid-analysis)
to include ILAMB v2.7, and then createexamples/ilamb
.