Create a new example that will run full ADF package (not from notebook) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This notebook should inject a link to the actual ADF output webpage into the jupyter book
cleaned up a couple files that were triggering pre-commit fails
hide input and output for imports, and input for cell that will eventually have plots as output
Notebook was linking to adf_root before updating the value from config.yml; config.yml should set the default to where we expect ADF to write webpage (which is in the same directory tree that CUPiD writes webpage)
|
The last thing we have to do here is to add a flag if ADF exists in build.py (Done week of 11/11) |
TeaganKing
reviewed
Nov 12, 2024
| @@ -45,6 +46,14 @@ def build(config_path): | |||
| subprocess.run( | |||
| ["jupyter-book", "build", f"{run_dir}/computed_notebooks/{sname}", "--all"], | |||
| ) | |||
| adf_run = control["compute_notebooks"]["atm"]["link_to_ADF"]["parameter_groups"][ | |||
| "none" | |||
| ]["adf_run"] | |||
There was a problem hiding this comment.
Could generalize for all components. Also use .get() to set default run_external_pkg value.
|
We should also add documentation on how to run ADF until #105 is resolved (Done 11/13) |
instead of adf_run: True adf_vars: ['...', '...'] Introduced external_tool: tool_name: 'ADF' vars: ['...', '...'] I also moved this out of parameter_group since it's not needed by the link_to_ADF.ipynb notebook (and added plotting_scripts: ['...', '...'] as an extra option to set in config.yml)
TeaganKing
reviewed
Nov 15, 2024
| adf_run: True | ||
| adf_vars: ['PRECT', 'SST'] | ||
| external_tool: | ||
| tool_name: 'ADF' |
There was a problem hiding this comment.
This is great! One thought-- if we eventually want to loop through multiple tools, should the ADF-specific parameters be a subset of the ADF tool?
|
We may want to remove the dependency on CESM (rather than just CUPiD and ADF)-- see note in #142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example can be generalized to other outside diagnostic packages as well (e.g. ILAMB). The goal is to have the JupyterBook-generated web site link to the ADF website from the side bar.
All Submissions:
pre-commitcheck)?New Feature Submissions:
Changes to Core Features: