Separate subroutines for barycentric interpolation into barycentric_utilities_mod.f90 #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since the barycentric interpolation routines are used by more than one
model_mod
, this pull request extracts the subroutines into a separatebarycentric_utilities_mod.f90
.Fixes issue
Fixes issue #764 Feature request: Barycentric interpolation module.
Types of changes
Documentation changes needed?
Not yet. Documentation changes will be written when the actual model mods are changed.
Tests
I removed the five subroutines stored in the aether_cube_sphere model_mod.f90 and instead imported them from the utilities module:
I reran
quickbuild.sh
and everything compiled. After that, I ranmodel_mod_check
and all of the checks passed.Checklist for merging
Note well: I can edit the changelog and conf.py once the pull request has been reviewed. However, I haven't done so at this time because on past pull requests, the code took long enough to merge that my edits to the changelog and conf.py became obsolete.
Checklist for release
Testing Datasets
Instructions for downloading the testing datasets, and the model_mod.f90 used to test this pull request are available on the aether_cube_sphere branch.