Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#122 #118

Merged
merged 8 commits into from
Feb 14, 2024
Merged

UFS-dev PR#122 #118

merged 8 commits into from
Feb 14, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Dec 4, 2023

Identical to ufs-community#1941

There are two new tests:

gnv1_c96_no_nest_debug - The standard C96 initial conditions used for most physics suites, configured to run global_nest_v1. This is run in debug mode for both compilers
gnv1_nested - Run off of the HAFS global static nest test initial conditions, this tests the suite in a static nest.

Contains

DeniseWorthen and others added 6 commits November 8, 2023 07:54
* update FD and some nems configs

* all except lnd sbs run

* update FD and nems.configure

* remove temporary test settings

* remove history_n settings from one more test
…active (ufs-community#1953)

Added new condition turning off samfdeepcnv, when the MYNN shallow convection is active.
…tart (ufs-community#1946)

* Convert most global (uncoupled) and regional tests to use quilting restart

* use MOM6 test branch, modify mom6_files.cmake

* update MOM6 to include 20231106 NOAA-GFDL/rtd_fix

* Update cpld_control_p8 remove hera_gnu wall clock stipulation

---------

Co-authored-by: jiandewang <[email protected]>
Co-authored-by: WenMeng-NOAA  <[email protected]>
* update FD and nems.configure

* add new suite_FV3_global_nest_v1 to FV3

* new tests for global_nest_v1 suite

* update tests to match new gwd scheme

* Namelist changes from Mike Toy & adapt to changes from develop in FV3

* Merge FV3 NOAA-EMC/fv3atm#715 from @lisa-bengtsson

* remove unused tests/rap_clm_lake

* Update bl_date.conf

* note that gnv1_nested might work on s4

* Update cpld_control_p8 remove hera_gnu wall clock stipulation
@grantfirl grantfirl marked this pull request as ready for review February 7, 2024 23:05
@grantfirl
Copy link
Collaborator Author

Expected failures for ufs-community#1942:

rt_001_cpld_control_p8_mixedmode_intel.log:71:Test 001 cpld_control_p8_mixedmode_intel FAIL Tries: 2
rt_002_cpld_control_gfsv17_intel.log:70:Test 002 cpld_control_gfsv17_intel FAIL Tries: 2
rt_004_cpld_control_p8_intel.log:71:Test 004 cpld_control_p8_intel FAIL Tries: 2
rt_006_cpld_control_qr_p8_intel.log:71:Test 006 cpld_control_qr_p8_intel FAIL Tries: 2
rt_008_cpld_2threads_p8_intel.log:59:Test 008 cpld_2threads_p8_intel FAIL Tries: 2
rt_009_cpld_decomp_p8_intel.log:59:Test 009 cpld_decomp_p8_intel FAIL Tries: 2
rt_010_cpld_mpi_p8_intel.log:59:Test 010 cpld_mpi_p8_intel FAIL Tries: 2
rt_011_cpld_control_ciceC_p8_intel.log:71:Test 011 cpld_control_ciceC_p8_intel FAIL Tries: 2
rt_012_cpld_control_c192_p8_intel.log:59:Test 012 cpld_control_c192_p8_intel FAIL Tries: 2
rt_014_cpld_bmark_p8_intel.log:54:Test 014 cpld_bmark_p8_intel FAIL Tries: 2
rt_016_cpld_control_noaero_p8_intel.log:70:Test 016 cpld_control_noaero_p8_intel FAIL Tries: 2
rt_017_cpld_control_nowave_noaero_p8_intel.log:68:Test 017 cpld_control_nowave_noaero_p8_intel FAIL Tries: 2
rt_018_cpld_debug_p8_intel.log:59:Test 018 cpld_debug_p8_intel FAIL Tries: 2
rt_019_cpld_debug_noaero_p8_intel.log:58:Test 019 cpld_debug_noaero_p8_intel FAIL Tries: 2
rt_020_cpld_control_noaero_p8_agrid_intel.log:68:Test 020 cpld_control_noaero_p8_agrid_intel FAIL Tries: 2
rt_021_cpld_control_c48_intel.log:56:Test 021 cpld_control_c48_intel FAIL Tries: 2
rt_022_cpld_control_p8_faster_intel.log:71:Test 022 cpld_control_p8_faster_intel FAIL Tries: 2
rt_023_cpld_control_pdlib_p8_intel.log:70:Test 023 cpld_control_pdlib_p8_intel FAIL Tries: 2
rt_026_cpld_debug_pdlib_p8_intel.log:58:Test 026 cpld_debug_pdlib_p8_intel FAIL Tries: 2
rt_134_hafs_regional_atm_ocn_intel.log:15:Test 134 hafs_regional_atm_ocn_intel FAIL Tries: 2
rt_136_hafs_regional_atm_ocn_wav_intel.log:17:Test 136 hafs_regional_atm_ocn_wav_intel FAIL Tries: 2
rt_147_hafs_regional_storm_following_1nest_atm_ocn_intel.log:15:Test 147 hafs_regional_storm_following_1nest_atm_ocn_intel FAIL Tries: 2
rt_149_hafs_regional_storm_following_1nest_atm_ocn_debug_intel.log:13:Test 149 hafs_regional_storm_following_1nest_atm_ocn_debug_intel FAIL Tries: 2
rt_150_hafs_regional_storm_following_1nest_atm_ocn_wav_intel.log:17:Test 150 hafs_regional_storm_following_1nest_atm_ocn_wav_intel FAIL Tries: 2
rt_151_hafs_regional_docn_intel.log:14:Test 151 hafs_regional_docn_intel FAIL Tries: 2
rt_152_hafs_regional_docn_oisst_intel.log:14:Test 152 hafs_regional_docn_oisst_intel FAIL Tries: 2
rt_171_control_p8_atmlnd_sbs_intel.log:91:Test 171 control_p8_atmlnd_sbs_intel FAIL Tries: 2
rt_235_cpld_control_p8_gnu.log:71:Test 235 cpld_control_p8_gnu FAIL Tries: 2
rt_236_cpld_control_nowave_noaero_p8_gnu.log:68:Test 236 cpld_control_nowave_noaero_p8_gnu FAIL Tries: 2
rt_237_cpld_debug_p8_gnu.log:59:Test 237 cpld_debug_p8_gnu FAIL Tries: 2
rt_238_cpld_control_pdlib_p8_gnu.log:70:Test 238 cpld_control_pdlib_p8_gnu FAIL Tries: 2
rt_239_cpld_debug_pdlib_p8_gnu.log:58:Test 239 cpld_debug_pdlib_p8_gnu FAIL Tries: 2

@grantfirl
Copy link
Collaborator Author

Expected failure for ufs-community#1953

control_p8_mynn_intel

@grantfirl
Copy link
Collaborator Author

@mkavulich FYI, I kicked off tests for this one.

@grantfirl
Copy link
Collaborator Author

@mkavulich FYI, I kicked off tests for this one. I'm including the previous PR to save effort since it was a very minor change and affects different RTs.

@mkavulich
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/CCPP_regression_testing/NCAR_ufs-weather-model//run//1628610165/20240207231517/ufs-weather-model
[RT] Error: Test 001 cpld_control_p8_mixedmode_intel FAIL Tries: 2
[RT] Error: Test 002 cpld_control_gfsv17_intel FAIL Tries: 2
[RT] Error: Test 005 cpld_mpi_gfsv17_intel FAIL Tries: 2
[RT] Error: Test 006 cpld_debug_gfsv17_intel FAIL Tries: 2
[RT] Error: Test 007 cpld_control_p8_intel FAIL Tries: 2
[RT] Error: Test 009 cpld_control_qr_p8_intel FAIL Tries: 2
[RT] Error: Test 011 cpld_2threads_p8_intel FAIL Tries: 2
[RT] Error: Test 012 cpld_decomp_p8_intel FAIL Tries: 2
[RT] Error: Test 013 cpld_mpi_p8_intel FAIL Tries: 2
[RT] Error: Test 014 cpld_control_ciceC_p8_intel FAIL Tries: 2
[RT] Error: Test 015 cpld_control_c192_p8_intel FAIL Tries: 2
[RT] Error: Test 017 cpld_bmark_p8_intel FAIL Tries: 2
[RT] Error: Test 019 cpld_control_noaero_p8_intel FAIL Tries: 2
[RT] Error: Test 020 cpld_control_nowave_noaero_p8_intel FAIL Tries: 2
[RT] Error: Test 021 cpld_debug_p8_intel FAIL Tries: 2
[RT] Error: Test 022 cpld_debug_noaero_p8_intel FAIL Tries: 2
[RT] Error: Test 023 cpld_control_noaero_p8_agrid_intel FAIL Tries: 2
[RT] Error: Test 024 cpld_control_c48_intel FAIL Tries: 2
[RT] Error: Test 025 cpld_control_p8_faster_intel FAIL Tries: 2
[RT] Error: Test 026 cpld_control_pdlib_p8_intel FAIL Tries: 2
[RT] Error: Test 029 cpld_debug_pdlib_p8_intel FAIL Tries: 2
[RT] Error: Test 053 control_p8_mynn_intel FAIL Tries: 2
[RT] Error: Test 110 gnv1_c96_no_nest_debug_intel FAIL Tries: 2
[RT] Error: Test 133 hafs_regional_atm_ocn_intel FAIL Tries: 2
[RT] Error: Test 135 hafs_regional_atm_ocn_wav_intel FAIL Tries: 2
[RT] Error: Test 142 hafs_regional_storm_following_1nest_atm_ocn_intel FAIL Tries: 2
[RT] Error: Test 144 gnv1_nested_intel FAIL Tries: 2
[RT] Error: Test 145 hafs_regional_storm_following_1nest_atm_ocn_debug_intel FAIL Tries: 2
[RT] Error: Test 146 hafs_regional_storm_following_1nest_atm_ocn_wav_intel FAIL Tries: 2
[RT] Error: Test 147 hafs_regional_docn_intel FAIL Tries: 2
[RT] Error: Test 148 hafs_regional_docn_oisst_intel FAIL Tries: 2
[RT] Error: Test 167 control_p8_atmlnd_sbs_intel FAIL Tries: 2
[RT] Error: Test 189 hrrr_control_gnu FAIL Tries: 2
[RT] Error: Test 211 gnv1_c96_no_nest_debug_gnu FAIL Tries: 2
[RT] Error: Test 231 cpld_control_p8_gnu FAIL Tries: 2
[RT] Error: Test 232 cpld_control_nowave_noaero_p8_gnu FAIL Tries: 2
[RT] Error: Test 233 cpld_debug_p8_gnu FAIL Tries: 2
[RT] Error: Test 234 cpld_control_pdlib_p8_gnu FAIL Tries: 2
[RT] Error: Test 235 cpld_debug_pdlib_p8_gnu FAIL Tries: 2
[RT] Log file shows failures.
[RT] Please obtain logs from /scratch1/BMC/gmtb/CCPP_regression_testing/NCAR_ufs-weather-model//run//1628610165/20240207231517/ufs-weather-model

@mkavulich
Copy link
Collaborator

@grantfirl It looks like there's a pretty substantial difference between the expected failures and the actual ones. Are you sure this is the correct list?

@grantfirl
Copy link
Collaborator Author

@grantfirl It looks like there's a pretty substantial difference between the expected failures and the actual ones. Are you sure this is the correct list?

I see that the following tests aren't necessarily the same as the expected ones:
cpld_mpi_gfsv17_intel
cpld_debug_gfsv17_intel
gnv1_c96_no_nest_debug_intel
gnv1_c96_no_nest_debug_gnu
hrrr_control_gnu

I'll investigate these. Since new tests were added, the test numbers are definitely shuffled around.

@grantfirl
Copy link
Collaborator Author

The gnv* ones are expected due to ufs-community#1941

@grantfirl
Copy link
Collaborator Author

It looks like ufs-community#1941 should change the cpld* tests too. It looks like those got missed in the original PR description.

@grantfirl
Copy link
Collaborator Author

ufs-community#1941 is change rap.nml.in which is used by hrrr_control_gnu. I don't know why other hrrr_control tests wouldn't fail though.

@grantfirl
Copy link
Collaborator Author

@mkavulich I'm not entirely sure why hrrr_control_gnu changes results. I'm kinda wondering if maybe there was something amiss with a previous PR we merged, e.g. the baseline was corrupted from the last PR or something. Either way, I'm not too concerned about it and I don't want to spend too much more time digging into it. I personally feel comfortable creating new baselines at this point. Do you?

@mkavulich
Copy link
Collaborator

@grantfirl That sounds good to me. I didn't realize the numbering had changed, so I thought we were dealing with a much larger number of differences. I'll kick off the baseline creation.

@mkavulich
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/CCPP_regression_testing/NCAR_ufs-weather-model//run//1628610165/20240208170018/ufs-weather-model
Please make changes and add the following label back: hera-intel-BL

Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once submodule is updated

@grantfirl grantfirl merged commit 2f53232 into NCAR:main Feb 14, 2024
@grantfirl grantfirl mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants