Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clone, pull & remove features #52

Merged
merged 15 commits into from
Feb 9, 2024

Conversation

matiasberaldo
Copy link
Collaborator

@matiasberaldo matiasberaldo commented Jan 27, 2024

This PR expands bos-workspace capabilities by introducing the following features:

  • bos-workspace clone <account_id>: This command will download and create all the folder structure under apps for a given account
  • bos-workspace pull <account_id>: When the cloning command is executed, the account gets added to a tree saved as tree.json in the root directory. Thanks to this, it is possible to know if your local version matches the one coming from the blockchain, and only write new or modified files.
  • bos-workspace remove <account_id>: This command will delete the account components under the app directory. This method is necessary in order to refresh deleted accounts from the tree and keep it healthy.

Thanks!

@elliotBraem elliotBraem requested a review from sekaiking January 27, 2024 20:04
@elliotBraem
Copy link
Contributor

elliotBraem commented Jan 28, 2024

I've checked it out, it's a really convenient feature. I used it to initialize every.near; you can see that commit here

@sekaiking I'm wondering how this might be integrated with the v1.0.0?

Feedback

  • Clone should add a bos.config.json w/ appAccount so it can run in the workspace. See this commit
  • Is there a limit to number of files? I could clone devs.near fine (104 files), but get an error cloning big account like hack.near (300+)
Screenshot 2024-01-27 at 8 01 33 PM

@matiasberaldo
Copy link
Collaborator Author

Hello @elliotBraem, thanks for your feedback! I have added the requested feature of initializing the bos.config.json file and added support for downloading a huge number of components from an account.

@elliotBraem elliotBraem merged commit e4d6cec into main Feb 9, 2024
2 checks passed
@elliotBraem elliotBraem deleted the feature/download-and-sync-multiple-accounts branch March 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants