-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limits to reading XML inputs #319
Conversation
General question: Do we want to use 100M for everything or distinguish between the attributes and the content and use a much smaller value for the attributes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some small formatting changes and also changed the u128
used for the limit into a u64
. You could argue it could also be a usize
– the machine running the code can’t keep more than that in memory, anyway.
New * `ca::idexchange::Error` now impls `std::error::Error`. ([#297]) * Re-export `bcder` as `dep::bcder` if it is enabled. ([#299]) * Added `PublisherRequest::set_publisher_handle`. ([#300]) * Added `uri::{Rsync,Https}::path_into_dir` ([#302]) * Added `Ipv4Block` and `Ipv6Block` and `FromIterator` impls for `Ipv4Blocks` and `Ipv6Blocks`. ([#298]) * Made `AddressRange` public and added methods to convert ranges into a set of prefixes. ([#306]) * Updated the ASPA RTR PDU to conform with version -14 of draft-ietf-sidrops-8210bis. ([#309]) * Enable ASPA version 2 in the RTR server. ([#318]) * The ASPA `ProviderAsSet` now keeps track of its length and exposes it via the new `len` method. ([#315]) * The ASPA Provider AS Set is now limited to 16380 entries when parsing from ASPA objects and creating RTR PDUs. ([#316]) * Exposed `ca::idcert::TbsIdCert::validity`. ([#310]); * Protect against maliciously large XML input to the RRDP parser. This will allow re-enabling GZIP support in RRDP clients. ([#319]) Bug fixes * Do not allow backslashes in idexchange handles. ([#304]) * Check the content of file names in a manifest during parsing. This fixes a crash when later code assumes that the file names only contain ASCII characters and otherwise panics. ([#320]) Other changes * The minimum supported Rust version is now 1.73. ([#319])
This PR adds read limits to XML file parsing