Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filtering of D and revert obs QC #1226

Merged
merged 16 commits into from
Jul 30, 2024

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Jul 17, 2024

This PR adds a bit more flexibility to the filtering of D, making use of the generic diffusion and allowing for much larger scales that the simple filtering that we used before.
I also reverted the sst obs error to something a bit more realistic.

This work will now require a companion PR in the global-workflow

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jul 17, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 17, 2024
@emcbot
Copy link

emcbot commented Jul 18, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jul 17 23:22:08 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jul 18 00:05:01 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jul 18 00:29:21 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 47

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 18, 2024
@guillaumevernieres guillaumevernieres changed the title Tools to reduce the size of the ocean increments Better filtering of D and revert obs QC Jul 18, 2024
@guillaumevernieres guillaumevernieres added the orion-GW-RT Queue for automated testing with global-workflow on Orion label Jul 18, 2024
guillaumevernieres and others added 10 commits July 24, 2024 10:05
These changes encompass the work @guillaumevernieres and
@JohnSteffen-NOAA have done recently to incorporate a constant bkg error
for satellite SST obs, assigns an obs error multiplier filter that can
be adjusted, and comments out broken in situ obs filters.
Some of the in situ obs yaml files were not indented properly when
copying over the filters for the obs error multiplier.

---------

Co-authored-by: Guillaume Vernieres <[email protected]>
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jul 30, 2024
@guillaumevernieres guillaumevernieres marked this pull request as ready for review July 30, 2024 19:03
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 30, 2024
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing obviously wrong

@emcbot
Copy link

emcbot commented Jul 30, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Jul 30 19:24:59 UTC 2024 on hfe06
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jul 30 20:11:57 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jul 30 20:33:27 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 43

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 30, 2024
@guillaumevernieres guillaumevernieres merged commit f62b912 into develop Jul 30, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/diagb-filt-diff branch July 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscellaneous bugs Variance partitioning based on the correlation length scales QA/QC for marine obs
4 participants