-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better filtering of D and revert obs QC #1226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
added
the
hera-GW-RT
Queue for automated testing with global-workflow on Hera
label
Jul 17, 2024
emcbot
added
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
and removed
hera-GW-RT
Queue for automated testing with global-workflow on Hera
labels
Jul 17, 2024
Automated Global-Workflow GDASApp Testing Results:
|
emcbot
added
hera-GW-RT-Passed
Automated testing with global-workflow successful on Hera
and removed
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
labels
Jul 18, 2024
guillaumevernieres
changed the title
Tools to reduce the size of the ocean increments
Better filtering of D and revert obs QC
Jul 18, 2024
guillaumevernieres
added
the
orion-GW-RT
Queue for automated testing with global-workflow on Orion
label
Jul 18, 2024
These changes encompass the work @guillaumevernieres and @JohnSteffen-NOAA have done recently to incorporate a constant bkg error for satellite SST obs, assigns an obs error multiplier filter that can be adjusted, and comments out broken in situ obs filters.
Some of the in situ obs yaml files were not indented properly when copying over the filters for the obs error multiplier. --------- Co-authored-by: Guillaume Vernieres <[email protected]>
guillaumevernieres
added
hera-GW-RT
Queue for automated testing with global-workflow on Hera
and removed
orion-GW-RT
Queue for automated testing with global-workflow on Orion
hera-GW-RT-Passed
Automated testing with global-workflow successful on Hera
labels
Jul 30, 2024
guillaumevernieres
requested review from
apchoiCMD,
givelberg and
KatherineLukens-NOAA
July 30, 2024 19:04
7 tasks
emcbot
added
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
and removed
hera-GW-RT
Queue for automated testing with global-workflow on Hera
labels
Jul 30, 2024
AndrewEichmann-NOAA
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing obviously wrong
Automated Global-Workflow GDASApp Testing Results:
|
emcbot
added
hera-GW-RT-Passed
Automated testing with global-workflow successful on Hera
and removed
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
labels
Jul 30, 2024
JohnSteffen-NOAA
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bit more flexibility to the filtering of D, making use of the generic diffusion and allowing for much larger scales that the simple filtering that we used before.
I also reverted the sst obs error to something a bit more realistic.
This work will now require a companion PR in the
global-workflow