Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes prepoceanobs to using newly refactored BUFR converters #1352

Merged
merged 14 commits into from
Nov 13, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Just like the title. This mainly changes the converters used to the new ones that use yaml files, the templates for which are included, along with a little script that does most of the work of converting the earlier JSON templates to yaml. Also removes from ocean.py some methods for plotting, but can't go into global-workflow because of lack of the necessary python modules in that environment.

@RussTreadon-NOAA
Copy link
Contributor

Install this GDASApp PR and g-w PR #2992 on Hera. Run test_gdasapp ctests. The following tests fail in both installations

        1953 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
        1954 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
        1955 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
        1956 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
        1957 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
        1958 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
        1959 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
        1960 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)

Each of these jobs fail with the error message

    from b2iconverter.bufr2ioda_converter import Bufr2ioda_Converter
  File "/scratch1/NCEPDEV/da/Russ.Treadon/git/GDASApp/pr1352/ush/ioda/bufr2ioda/marine/b2i/b2iconverter/bufr2ioda_converter.py", line 7, in <module>
    from pyiodaconv import bufr
ModuleNotFoundError: No module named 'pyiodaconv'

Do we have a fix for these failures in the development pipeline?

@guillaumevernieres
Copy link
Contributor

Thanks for pointing this out @RussTreadon-NOAA . I created an issue off of your comment above.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Nov 12, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 12, 2024
@emcbot
Copy link

emcbot commented Nov 12, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Tue Nov 12 20:09:02 UTC 2024 on hfe06
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Nov 12 20:56:57 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Nov 12 22:57:31 UTC 2024
Tests: 80% tests passed, 13 tests failed out of 64
	1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marinebmat_202103241800 (Failed)
	1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlinit_202103241800 (Failed)
	1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlvar_202103241800 (Failed)
	1958 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
	1959 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlfinal_202103241800 (Failed)
	1968 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlletkf_202103241800 (Failed)
	1972 - test_gdasapp_atm_jjob_var_init (Failed)
	1973 - test_gdasapp_atm_jjob_var_run (Failed)
	1974 - test_gdasapp_atm_jjob_var_inc (Failed)
	1975 - test_gdasapp_atm_jjob_var_final (Failed)
	1980 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1981 - test_gdasapp_atm_jjob_ens_inc (Failed)
	1982 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1352/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 12, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci failure isn't related to this PR, I forgot that the b-matrix pr was merged and develop will be broken until the g-w pr is merged as well.
I'm merging this keeping in mind (right ...) that we might have to revert your changes to the obs list yaml.

@guillaumevernieres guillaumevernieres merged commit 6bc2760 into develop Nov 13, 2024
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/bufrconv branch November 13, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants